sync up with fork #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove sys.path modification from library
g.nodes_iter() -> g.nodes() g.node[...] -> g.nodes[...]
g.edges_iter() -> g.edges() g.edge[...] -> g.edges[...]
Fix windows pickling issue
when `g.remove_edges_from()` is called with a view as an argument, such as `g.out_edges(n)`, a RuntimeError is raised: RuntimeError: dictionary changed size during iteration removal changes the view. can be worked around by creating a list: `g.remove_edges_from(list(g.out_edges(n)))`
reflect sklearn now requiring a ndarray as feature vector
fix remove_edges_from called with view
py37 doesn't support Pathlib objs in subprocess args on windows https://bugs.python.org/issue41649
prepare for for next rebuild cycle
indexing with lists got deprecated in numpy
object ids are updated based on the sequence of objectd ids which is not guaranteed to be the same every time.
for some reason on linux ci (not on any other machines I could test) this test failed with 1ulp accuracy.
Reproducible merger resolvers
k-dominik
commented
Feb 14, 2024
There was a problem hiding this comment.
I didn't go through the changes in detail - we did on the fork already. I just made sure nothing super odd would be merged in.
Changes are
- many formatting changes
- removed some odd patterns
- changes for networkx 2 upgrade
- added ci
- fixed pickling issues on win
- sklearn related updates
- h5py deprecations
- reproducible merger resolvers (seeded gmm init)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.