Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1-4-15 ThreeSumFaster 中的 while 循环条件 #595

Closed
Higurashi-kagome opened this issue Feb 18, 2022 · 4 comments
Closed

1-4-15 ThreeSumFaster 中的 while 循环条件 #595

Higurashi-kagome opened this issue Feb 18, 2022 · 4 comments
Labels
FIXED 问题已修复

Comments

@Higurashi-kagome
Copy link
Contributor

1.4.15/Program.cs#L76 中，似乎应该是 lo < hi。
@Higurashi-kagome
Copy link
Contributor Author

另：1.4.20/Program.cs#L70 中似乎应该是 lo <= hi。

@ikesnowy
Copy link
Owner

感谢你的反馈，但没有具体理由的话，我会先把时间放在有明确内容的其他事情上，你的 issue 会延后处理。

@Higurashi-kagome
Copy link
Contributor Author

Higurashi-kagome commented Feb 20, 2022 •
edited
Loading

1.4.15/Program.cs#L76 中，似乎应该是 lo < hi。

求 {-4, 0, 2, 3} 的三元组返回 1，实际上应该是 0。

另：1.4.20/Program.cs#L70 中似乎应该是 lo <= hi。

在 {5, 4} 中找 4，返回 -1，实际上应该是 1。

ikesnowy added a commit that referenced this issue Mar 13, 2022
@ikesnowy
Merge pull request #610 from ikesnowy/595-fix-binary-search-condition
b42e0d4 
fix: #595
@ikesnowy ikesnowy added the FIXED 问题已修复 label Mar 13, 2022
@ikesnowy
Copy link
Owner

感谢，已经修复了这两个问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FIXED 问题已修复
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ikesnowy @Higurashi-kagome