Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR REQUESTss FOR Backend Server Set Up #7 #19

Closed
wants to merge 1 commit into from
Closed

PR REQUESTss FOR Backend Server Set Up #7 #19

wants to merge 1 commit into from

Conversation

rishyym0927
Copy link

Hello @monarxxjain,

This pull request addresses Issue #7 regarding the Backend Server Set Up. I've created a new branch to implement the changes you suggested for configuring the backend. Additionally, I've updated the .gitignore files and installed all the required dependencies.

@monarxxjain
Copy link

Can you please explain me what exactly is happening in server1.js and server2.js
And why earlier you opened pull request without even adding expressJs dependency.

While your code seems correct, we can merge once you explain above questions in your own words.

@rishyym0927
Copy link
Author

rishyym0927 commented Mar 15, 2024

okay in previous pull request my express JS dependency was not installed properly due to some glitch that is why it was not shown. It was working because I have add if conditions , if .env file are not configured. Server1.js basically use nodeJs to run the server whereas Server2.js uses expressJS to Run the server. In scripts If you run npm run start it will start server2.js. I have created a new pull request because in previous ones node modules were also pushed and I was not able to revert back my commits.

@monarxxjain
Copy link

Ok understandable, great work @rishyym0927.

@monarxxjain
Copy link

This PR is associated with #16

@monarxxjain monarxxjain added the accepted-4 4 points label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted-4 4 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants