Intergation custom table view to vc #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mishania13
approved these changes
Nov 1, 2022
IvanKrim
approved these changes
Nov 1, 2022
firuz1844
requested changes
Nov 2, 2022
| @@ -22,4 +22,15 @@ extension Date { | |||
| func year() -> Int { | |||
| return Calendar.current.component(.year, from: self) | |||
| } | |||
|
|
|||
| func timeOnly() -> Float { | |||
There was a problem hiding this comment.
честно сказать, так и не понял, что этот метод возвращает... Float... Time... В каких единицах измерения возвращается timeOnly?
| if let yToScroll = timeline.currentTimeYPosition { | ||
| setTimelineOffset(CGPoint(x: contentOffset.x, y: yToScroll - padding), animated: animated) | ||
| } | ||
| let timeToScroll = Date().timeOnly() - 4 |
There was a problem hiding this comment.
Тут еще какие-то магические 4 единицы чего-то отнимаются...
| } | ||
|
|
||
| private func setTimelineOffset(_ offset: CGPoint, animated: Bool) { | ||
| let yToScroll = offset.y | ||
| let bottomOfScrollView = contentSize.height - bounds.size.height | ||
| let bottomOfScrollView = contentSize.height - bounds.size.height + 30 |
| @@ -43,6 +43,8 @@ public final class TimelinePagerView: UIView, UIGestureRecognizerDelegate, UIScr | |||
| } | |||
|
|
|||
| public var autoScrollToFirstEvent = false | |||
|
|
|||
| public var minDate: Date? | |||
There was a problem hiding this comment.
Добавить бы комментарий с описанием, что это за минимальная дата и для чего она используется
JohnnyThompson
approved these changes
Nov 3, 2022
firuz1844
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.