Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: automatic migrate the buf configs to v2 #4494

Merged
merged 8 commits into from
Feb 7, 2025
Merged

feat: automatic migrate the buf configs to v2 #4494

merged 8 commits into from
Feb 7, 2025

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Feb 3, 2025 •
edited
Loading

Description

  • Automatic migrate the buf configs to v2 using the buf config migrate command with the doctor comands;
  • Migrate the buf.gen yaml to v2;

@Pantani Pantani self-assigned this Feb 3, 2025
@Pantani Pantani changed the title feat: bug.gen.yaml v2 feat: automatic migrate the buf configs to v2 Feb 4, 2025
@Pantani Pantani marked this pull request as ready for review February 4, 2025 02:30
@Pantani Pantani marked this pull request as draft February 4, 2025 04:05
julienrbrt
julienrbrt reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just read through those and left some suggestions

ignite/templates/app/files/{{protoDir}}/buf.gen.gogo.yaml Outdated Show resolved Hide resolved
ignite/pkg/cosmosbuf/buf.go Show resolved Hide resolved
@Pantani Pantani marked this pull request as ready for review February 5, 2025 23:44
@Pantani Pantani requested a review from julienrbrt February 6, 2025 00:09
julienrbrt
julienrbrt approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏾

@julienrbrt julienrbrt merged commit 1ebcda2 into main Feb 7, 2025
42 of 45 checks passed
@julienrbrt julienrbrt deleted the feat/buf-migrate branch February 7, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@Pantani Pantani

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:packages component:templates type:internal type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pantani @julienrbrt