-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): add HD wallet parameters address index
and account number
to the chain account config
#3999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
address index
and account number
HD parametersaddress index
and account number
HD wallet parameters
address index
and account number
HD wallet parametersaddress index
and account number
address index
and account number
address index
and account number
to the chain account config
address index
and account number
to the chain account configaddress index
and account number
to the chain account config
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3999 +/- ##
==========================================
- Coverage 26.13% 26.11% -0.03%
==========================================
Files 304 304
Lines 25303 25331 +28
==========================================
Hits 6614 6614
- Misses 18112 18140 +28
Partials 577 577
|
julienrbrt
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
…umber` to the chain account config (#3999) * add address index and account number flags to the add keys command * add changelog --------- Co-authored-by: Pantani <Pantani>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:ci
CI/CD workflow and automated jobs.
component:configs
component:packages
type:internal
type:services
Service-related issues.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3967
Description
Add address index and account number to the chain config to be added into the key add command flag.
How to test
Scaffold a mars chain (
ignite s chain mars
) and use this testconfig.yml
file:ignite c serve --clear-cache --reset-once
, and you can see the Alice address will becosmos19jn5wrfgd0tgrh083u0qe54tj03esg68kyu6tz
:Blockchain is running ✔ Added account alice with address cosmos19jn5wrfgd0tgrh083u0qe54tj03esg68kyu6tz and mnemonic: apple pony round crazy boil solid inch beef equal attract soul accuse nice thumb shadow egg drum valley grace wish elbow hat salute pair ✔ Added account bob with address cosmos1ns5jkh9hqpxnpqkz34yt0wlzwvnfu8nfej0fd7 and mnemonic: birth various position huge derive sugar endorse cliff group muscle report festival there trash fluid morning trend bargain razor sister aunt melody injur 🌍 Tendermint node: http://0.0.0.0:26657 🌍 Blockchain API: http://0.0.0.0:1317 🌍 Token faucet: http://0.0.0.0:4500 ⋆ Data directory: /Users/danilopantani/.mars ⋆ App binary: /Users/danilopantani/Desktop/go/bin/marsd Press the 'q' key to stop serve
You can check the wallet generation using the Ian Coleman tool