chore: small improvements gacli #3789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
requested review from
ilgooz,
jeronimoalbi,
Pantani and
Ehsan-saradar
as code owners
Pantani
approved these changes
Nov 29, 2023
julienrbrt
commented
Nov 29, 2023
| @@ -22,7 +22,6 @@ require ( | |||
| github.com/99designs/keyring v1.2.2 | |||
| github.com/AlecAivazis/survey/v2 v2.3.7 | |||
| github.com/DATA-DOG/go-sqlmock v1.5.0 | |||
| github.com/Pallinder/go-randomdata v1.2.0 | |||
There was a problem hiding this comment.
I think we should not add external libraries for everything. Here it was used only for random names.
Which I find overkilled to have a library for that. We can as well just use the hostname.
ilgooz
pushed a commit
that referenced
this pull request
Dec 1, 2023
* add googla analytics * add doNotTrack env var * add changelog * add anlytics into a cobra command * improve analyticcs * run make format * fix file check * fix env var * fix send metrics in parallel * move vars to const * Update ignite/cmd/ignite/analytics.go Co-authored-by: Jerónimo Albi <[email protected]> * Update ignite/cmd/ignite/main.go Co-authored-by: Jerónimo Albi <[email protected]> * improve analytics msg * update ga pkg * improve analytics init * use http post request instate a libraty * add GA Client ID * use postform instead newrequest * use set instead literals for url.Values * add ga4 http metric send * fix url and values * chore: small improvements gacli (#3789) * chore: small improvements gacli * duplicate * remove sensitive data * remove sensitive data and improve the parameters * refactor: good default http client for ga (#3791) * refactor: good default http client * use client * ilker feedback * lint * remove `Pallinder/go-randomdata` pkg * set the ignite telemetry endpoint * remove the url from the pkg and change some var names * move telemetry to the internal package * use snake case for anon identity file --------- Co-authored-by: Pantani <Pantani> Co-authored-by: Jerónimo Albi <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes do not track logic.