Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use DefaultBaseappOptions for app.New method #3614

Merged
merged 8 commits into from
Sep 2, 2023

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Aug 5, 2023

close #3600

@Pantani Pantani self-assigned this Aug 5, 2023
jeronimoalbi
jeronimoalbi previously approved these changes Aug 7, 2023
Copy link
Contributor

@max-hontar max-hontar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pantani Pantani merged commit 45b57f0 into main Sep 2, 2023
@Pantani Pantani deleted the feat/add-default-baseapp-options branch September 2, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some options missing in App constructor
3 participants