-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ICS chains in ts-client generation #3444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .go file changes look ok I think. WIll let @ilgooz and co. double check those.
The client.ts.tpl
changes are all part of the function that "suggests" a new chain to Keplr.
Has Keplr updated/documented use of this function for ICS chains yet or is this simply what we expect it to look like?
As for now they are aware of this issue. I've created an github issue suggesting making stakeCurrency optional. Anyway after possible new Keplr API changes introduced there won't be much changes needed to Ignite |
ok cool. we might as well update/revisit this when we have some more details |
@ratik would you add an entry for the feature to the |
* feat: support ICS chains * feat: reverse condition to make IsConsumerChain false by default * docs: update changelog * docs: update changelog * docs: small changelog.md section fix --------- Co-authored-by: Jerónimo Albi <[email protected]>
There is a Replicated Security feature introduced recently. So this one means that chain won't have staking module and will rely on provider security(ie validators/staking).
This PR consist of detection if the app has staking module and generation logic for
ts-client