Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(template): wrong client context for cmd query methods #3441

Merged
merged 2 commits into from
Feb 27, 2023
Merged

fix(template): wrong client context for cmd query methods #3441

merged 2 commits into from
Feb 27, 2023

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Feb 24, 2023

close #3435

@Pantani Pantani requested a review from ilgooz February 24, 2023 06:32
@Pantani Pantani self-assigned this Feb 24, 2023
@ilgooz ilgooz added the type:error Something isn't working label Feb 27, 2023
@ilgooz ilgooz merged commit 99e6c5c into main Feb 27, 2023
@ilgooz ilgooz deleted the fix/query-client-ctx branch February 27, 2023 06:18
@RaulBernal
Copy link
Contributor

Hi @Pantani it seems to solve the CLI queries but LCD queries lacks the solution 🙏
As I said in #3435

In example: curl http://localhost:1317/BitCannaGlobal/bcna/bcna/bitcannaid/0?height=100```

@RaulBernal RaulBernal mentioned this pull request Mar 24, 2023
Closed
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@Pantani
fix(template): wrong client context for cmd query methods (ignite#3441)
881bea3 
* fix query contexts

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz ilgooz approved these changes

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@tbruyelle tbruyelle Awaiting requested review from tbruyelle

Assignees

@Pantani Pantani

Labels
type:error Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Height param is not processed querying custom module/list
3 participants
@Pantani @RaulBernal @ilgooz