Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable mouse support from ignite docs #3385

Merged
merged 3 commits into from
Jan 7, 2023
Merged

fix: disable mouse support from ignite docs #3385

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
279397e
fix: disable mouse support from `ignite docs`
jeronimoalbi Jan 6, 2023
5bb16fd
Merge branch 'main' into fix/docs-command
Jan 6, 2023
0ad7e7e
Merge branch 'main' into fix/docs-command
Jan 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
- [#3203](https://github.com/ignite/cli/issues/3203) Fix relayer to work with multiple paths.
- [#3320](https://github.com/ignite/cli/pull/3320) Allow `id` and `creator` as names when scaffolding a type.
- [#3327](https://github.com/ignite/cli/issues/3327) Scaffolding messages with same name leads to aliasing.
- [#3379](https://github.com/ignite/cli/issues/3379) Fix `ignite docs` issue by disabling mouse support.

## [`v0.25.2`](https://github.com/ignite/cli/releases/tag/v0.25.1)

Expand Down
12 changes: 1 addition & 11 deletions ignite/pkg/markdownviewer/markdownviewer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,9 @@ func View(path string) error {
return err
}

// TODO: Enable bubbletea WithAltScreen and WithMouseCellMotion options when glow supports them
p := ui.NewProgram(conf)

// TODO: refactor to remove deprecated function calls
//nolint:staticcheck,nolintlint
p.EnterAltScreen()
//nolint:staticcheck,nolintlint
defer p.ExitAltScreen()

//nolint:staticcheck,nolintlint
p.EnableMouseCellMotion()
//nolint:staticcheck,nolintlint
defer p.DisableMouseCellMotion()

_, err = p.Run()
return err
}
Expand Down