Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Generated REST client method casing bug & JS additions #3068

Merged
merged 13 commits into from
Nov 10, 2022

Conversation

clockworkgr
Copy link
Collaborator

This PR fixes a bug where client method calls did not match the generated Rest API methods when the method contained multiple capital letters in a row.

It also introduces a few additions to the vuex store and ts-client generated packages to simplify working with JS projects.

Resulting code now has working transpilation configuration and vuex stores almost ready to publish.

Fixes: #3067

Copy link
Contributor

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't commend much on the TS code but overall lgtm

ignite/pkg/cosmosgen/generate_vuex.go Outdated Show resolved Hide resolved
tbruyelle
tbruyelle previously approved these changes Nov 7, 2022
Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

aljo242
aljo242 previously approved these changes Nov 9, 2022
@aljo242 aljo242 merged commit 69d3ee6 into develop Nov 10, 2022
@aljo242 aljo242 deleted the fix/for-js-users branch November 10, 2022 12:38
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
)

* fix: Naming bug and working with JS

* feat: add prevent publish with local dep check

* chore: More lifecycle scripts

* chore: remove gocase dependency as no longer used

* chore: address review comments

* chore: Update changelog

* chore: More review comments

* chore: Review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated vue and ts-client don't work together
4 participants