[bump minor] Pk1d z parts #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
armengau
commented
Jun 19, 2024
armengau
commented
- Option to compute P1D "chunks" according to predefined z bins, instead of 3 chunks in qso's restframe.
- At P1D postprocessing, if the former option was set, option to compute skyline mask correction matrices, and apply them.
|
I hope that 1. is done; but 2. is not ready yet so no merging yet... |
|
@armengau What is the status of this PR ? I think this branch is starting to diverge from the main picca version. |
Yes, doing some tests, will tell you if it's fine or needs an additional commit now (maybe not before the telecon..). |
corentinravoux
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.