Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Able to submit previously-released games #397

Closed
Keltena opened this issue Jul 22, 2024 · 0 comments · Fixed by #398
Closed

Able to submit previously-released games #397

Keltena opened this issue Jul 22, 2024 · 0 comments · Fixed by #398

Comments

@Keltena
Copy link
Contributor

Keltena commented Jul 22, 2024

The entry registration form asks, "Has this entry had any public playable release before IFComp this year?" It looks like if you answer yes, the form should 1) display a warning and 2) disable the submit button. Neither happens for me: I see no warning and am able to submit the entry as usual.

(Selecting a playtime of >2 hours should also make a warning appear; this doesn't work either.)

Tested in Firefox and Chrome on Windows 10.
Keltena added a commit to Keltena/ifcomp that referenced this issue Jul 24, 2024
@Keltena
Include scripts block. (Fixes the issue where warning about >2hr play…
47cc730 
…time didn't show, as mentioned in iftechfoundation#397.)
Keltena added a commit to Keltena/ifcomp that referenced this issue Jul 24, 2024
@Keltena
Select the correct element id to check if game is unreleased.
e3df4b6 
Fixes iftechfoundation#397, where previously-released entries failed to trigger a warning or disable submission.
@Keltena Keltena mentioned this issue Jul 24, 2024
Merged
mjmusante pushed a commit that referenced this issue Jul 31, 2024
@Keltena @mjmusante
Include scripts block. (Fixes the issue where warning about >2hr play…
32d93ca 
…time didn't show, as mentioned in #397.)
mjmusante pushed a commit that referenced this issue Jul 31, 2024
@Keltena @mjmusante
Select the correct element id to check if game is unreleased.
40eeb84 
Fixes #397, where previously-released entries failed to trigger a warning or disable submission.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix warnings in entry registration form Keltena/ifcomp
1 participant
@Keltena