Review tool: Send email when reviewer comes back from hiatus

[ietf-svn-bot]

keyword_sprint owner:[email protected] resolution_fixed type_enhancement | by [email protected]

---

Currently when a reviewer sets a hiatus in the review tool and then hiatus ends, there is no notification to the reviewer. If a reviewer had set a long hiatus - say, more than one month - it would be good for the reviewer to receive an email when they are about to be added back in rotation (maybe a few days before, like 3). This way the reviewer can make adjustments his or her availability.

It would also be nice if the secretary receives a notification email too.

---

Issue migrated from trac:2231 at 2022-03-04 05:47:01 +0000

[ietf-svn-bot]

@[email protected] changed priority from n/a to major

[ietf-svn-bot]

@[email protected] changed keywords from `` to sprint

[ietf-svn-bot]

@[email protected] commented

---

This would live in a cron job similar to expire-drafts

[ietf-svn-bot]

@[email protected] changed status from new to assigned

[ietf-svn-bot]

@[email protected] changed owner from `` to [email protected]

[ietf-svn-bot]

@[email protected] commented

---

The SoW suggests expanding https://trac.tools.ietf.org/tools/ietfdb/browser/trunk/ietf/bin/send-review-reminders for this and other email reminder features, to be periodically run by cron. Is that script currently actually used/run though?

I think not, or it's been producing errors, because I can't see how the reference to assignments on line 30 is valid. It also won't work in Python 3 due to the use of execfile() (not hard to fix).

[ietf-svn-bot]

@[email protected] commented

---

Checking both bin/hourly and bin/daily in the repository, and the cronjobs on the server which are not in the repo because they run as root, your conclusion seems impeccable -- send-review-reminders does not appear in any of them (.../manage.py send_reminders is run daily from bin/daily though).

(I realize that we may not have talked about the py27 vs. py36 situation -- maybe Robert has mentioned it? Since you mention Python 3, I should make sure to indicate that we're currently in a position where the code should be ready for a transition to Python 3 (py36 is the current indication) but while waiting for some other components to be Python 3 ready, and an OS upgrade on the server, we're running on Python 2.7. When I merge, I'm currently running the test suite on both Python 2 and 3.)

[ietf-svn-bot]

@[email protected] commented

---

The send_reminders management command mentioned is NomCom specific, and shouldn't be extended for reviews.

The intent was to add send-review-reminders to the cron jobs. I would have expected them to be wired in using the project's bin/daily file.

If making bin/send-review-reminders functional is a small task, please take it on, and wire it in as above. If it looks like unreasonable scope-creep, let me know and we'll address it.

[ietf-svn-bot]

@[email protected] commented

---

https://trac.tools.ietf.org/tools/ietfdb/changeset/16703 makes send-review-reminders functional, as far as I can determine.

[ietf-svn-bot]

@[email protected] changed status from assigned to closed

[ietf-svn-bot]

@[email protected] changed resolution from `` to fixed

[ietf-svn-bot]

@[email protected] commented

---

Fixed in 179c151:

Fix #2231 - Send reminders before long UnavailabilityPeriods expire

A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
Commit ready for merge.

[ietf-svn-bot]

@[email protected] commented

---

Fixed in 4c3e869:

Merged in 179c151 from [email protected]:
Fix #2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.