Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of typed two-parted scheduler #592

Merged
merged 46 commits into from
Nov 22, 2023

Conversation

sebastian-peter
Copy link
Member

Resolves #378

Some notes:
The new scheduler only stores one activation for an actor at a time.
This also means that trigger revocation happens automatically.

Adjacent changes are the following:

  • CompletionMessage can only contain one trigger and should only schedule the completing actor. For other schedulings, the ScheduleTriggerMessage is used (for now)
  • Removed actor reference from TriggerWithIdMessage, which has never been used

This is another step to move the scheduling mechanism in SIMONA more towards DEVS. There's more to come.

@sebastian-peter sebastian-peter added enhancement New feature or request speed Improves execution speed, leading to shorter runtimes labels Aug 23, 2023
@sebastian-peter sebastian-peter self-assigned this Aug 23, 2023
@sebastian-peter sebastian-peter added this to the Version 4.0 milestone Nov 13, 2023
@sebastian-peter sebastian-peter marked this pull request as ready for review November 13, 2023 14:43
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work especially for keeping ScalaDoc updated here as well. I mainly would like to double check if the todos are for the upcoming work - I least I guess so - and have some little questions.

@sebastian-peter sebastian-peter marked this pull request as ready for review November 20, 2023 10:51
@sebastian-peter sebastian-peter marked this pull request as draft November 20, 2023 11:04
@sebastian-peter sebastian-peter marked this pull request as ready for review November 20, 2023 11:17
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@danielfeismann danielfeismann merged commit 29304e5 into dev Nov 22, 2023
@sebastian-peter sebastian-peter deleted the sp/#378-simscheduler-typed branch November 22, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request speed Improves execution speed, leading to shorter runtimes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure and reimplement SimScheduler
2 participants