Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce squants #491

Merged
merged 208 commits into from
Sep 6, 2023
Merged

Introduce squants #491

merged 208 commits into from
Sep 6, 2023

Conversation

danielfeismann
Copy link
Member

resolves #490

This PR is build up mainly on work of @sebastian-peter in #338

@danielfeismann danielfeismann added the speed Improves execution speed, leading to shorter runtimes label Mar 17, 2023
@danielfeismann danielfeismann self-assigned this Mar 17, 2023
@danielfeismann
Copy link
Member Author

!test

t-ober
t-ober requested changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@t-ober t-ober left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another round done, we are getting there 🎉 😂

PS: There are some Sonarqube issues left which can be quite easily resolved.

danielfeismann
danielfeismann commented Aug 14, 2023
View reviewed changes
Copy link
Member Author

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: Ensure that results need to come in Megawatt

t-ober
t-ober approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thaaaanks Daniel - this was a tedious task 🥳 🎉

@t-ober t-ober merged commit 9270901 into dev Sep 6, 2023
@t-ober t-ober deleted the df/#490-squants branch September 6, 2023 11:43
@sebastian-peter sebastian-peter added this to the Version 4.0 milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staudtMarius staudtMarius staudtMarius left review comments

@t-ober t-ober t-ober approved these changes

@sebastian-peter sebastian-peter Awaiting requested review from sebastian-peter

@sensarmad sensarmad Awaiting requested review from sensarmad

@jo-bao jo-bao Awaiting requested review from jo-bao

@julianhohmann julianhohmann Awaiting requested review from julianhohmann

Assignees

@danielfeismann danielfeismann

Labels
speed Improves execution speed, leading to shorter runtimes
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging this pull request may close these issues.

Introduce scala squants for fast and typesafe calculations
4 participants
@danielfeismann @sebastian-peter @t-ober @staudtMarius