Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking the number of slack nodes. #1123

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Checking the number of slack nodes. #1123

merged 4 commits into from
Jan 28, 2025

Conversation

staudtMarius
Copy link
Member

Resolves #1122

@staudtMarius staudtMarius added the enhancement New feature or request label Jan 24, 2025
@staudtMarius staudtMarius self-assigned this Jan 24, 2025
@staudtMarius staudtMarius marked this pull request as ready for review January 24, 2025 13:48
danielfeismann
danielfeismann reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isnt this already handled here?

https://github.com/ie3-institute/simona/blob/dev/src/main/scala/edu/ie3/simona/io/grid/GridProvider.scala#L70-L73

@staudtMarius
Copy link
Member Author

Isnt this already handled here?

https://github.com/ie3-institute/simona/blob/dev/src/main/scala/edu/ie3/simona/io/grid/GridProvider.scala#L70-L73

It is partly addressed. The code you linked will only check one subgrid. It will also be removed with #1099. Therefore I added a check that takes all nodes of the grid into account.

@staudtMarius
Merge branch 'dev' into ms/#1122-check-number-of-slack-nodes
ce482a1 
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/io/grid/GridProvider.scala
@staudtMarius
fmt
eeca079
danielfeismann
danielfeismann approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielfeismann danielfeismann merged commit e88e8f9 into dev Jan 28, 2025
4 checks passed
@danielfeismann danielfeismann deleted the ms/#1122-check-number-of-slack-nodes branch January 28, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann approved these changes

Assignees

@staudtMarius staudtMarius

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check the number of slack nodes
2 participants
@staudtMarius @danielfeismann