Added support for topologies without transformers and slack grids with multiple nodes #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmers # Conflicts: # CHANGELOG.md
danielfeismann
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Just a minor thing. And please remove the changes from #1098
|
Fine for me so far, but please rollback the changes from #1098 since I guess they're obsolte now, or? |
Correct me, if I am wrong, but I think the changes are rolled back completely. |
Sorry, I overlooked that |
danielfeismann
requested changes
Jan 28, 2025
src/test/scala/edu/ie3/simona/agent/grid/PowerFlowSupportSpec.scala
Outdated
Show resolved
Hide resolved
danielfeismann
approved these changes
Jan 28, 2025
danielfeismann
deleted the
ms/#1099-allow-for-topologies-without-transformers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1099