Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PVModel and adjacent classes -> PvModel #326

Closed
sebastian-peter opened this issue Aug 31, 2022 · 0 comments · Fixed by #367
Closed

Refactor PVModel and adjacent classes -> PvModel #326

sebastian-peter opened this issue Aug 31, 2022 · 0 comments · Fixed by #367
Labels
code quality Code readability or efficiency is improved good first issue Good for newcomers

Comments

@sebastian-peter
Copy link
Member

Currently, PV-related classes are named PV[...], while our naming convention suggests using lower-case mode for consecutive letters belonging to abbrevations, like Pv[...] (e.g. PvModel).
@sebastian-peter sebastian-peter added good first issue Good for newcomers code quality Code readability or efficiency is improved labels Aug 31, 2022
@sebastian-peter sebastian-peter changed the title Refactor PVModel and adjacent classes Refactor PVModel and adjacent classes -> PvModel Aug 31, 2022
@vickybung1 vickybung1 mentioned this issue Oct 5, 2022
Merged
vickybung1 added a commit that referenced this issue Oct 10, 2022
@vickybung1
Merge branch 'dev' into vb/#326
9fa2b4a
danielfeismann added a commit that referenced this issue Oct 10, 2022
@danielfeismann
Merge pull request #367 from ie3-institute/vb/#326
2bcd5e4 
Adapted abbreviations in PVModel and adjacent classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Code readability or efficiency is improved good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adapted abbreviations in PVModel and adjacent classes ie3-institute/simona
1 participant
@sebastian-peter