Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify PrimaryServiceProxy with new version of PSDM #120

Closed
sebastian-peter opened this issue Jan 27, 2022 · 0 comments · Fixed by #121
Closed

Simplify PrimaryServiceProxy with new version of PSDM #120

sebastian-peter opened this issue Jan 27, 2022 · 0 comments · Fixed by #121
Assignees
@sebastian-peter
Labels
code quality Code readability or efficiency is improved

Comments

@sebastian-peter
Copy link
Member

With recent changes to ColumnScheme in PSDM, the PrimaryServiceProxy can be simplified a bit.
@sebastian-peter sebastian-peter added the code quality Code readability or efficiency is improved label Jan 27, 2022
@sebastian-peter sebastian-peter self-assigned this Jan 27, 2022
@sebastian-peter sebastian-peter mentioned this issue Jan 27, 2022
Merged
sebastian-peter added a commit that referenced this issue Feb 15, 2022
@sebastian-peter
Merge branch 'dev' into sp/#120-simplify-PrimaryServiceProxy
1454cc1 
# Conflicts:
#	CHANGELOG.md
#	src/test/scala/edu/ie3/simona/service/primary/PrimaryServiceProxySpec.scala
#	src/test/scala/edu/ie3/simona/service/primary/PrimaryServiceWorkerSpec.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastian-peter sebastian-peter

Labels
code quality Code readability or efficiency is improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplifying PrimaryServiceProxy with new changes from PSDM snapshot ie3-institute/simona
1 participant
@sebastian-peter