Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do some renaming within thermals #1193

Closed
danielfeismann opened this issue Feb 17, 2025 · 0 comments · Fixed by #1194
Closed

Do some renaming within thermals #1193

danielfeismann opened this issue Feb 17, 2025 · 0 comments · Fixed by #1194
Labels
code quality Code readability or efficiency is improved

Comments

@danielfeismann
Copy link
Member

  • HouseTemperatureUpperBoundaryReached should be renamed to HouseTemperatureTargetOrUpperBoundaryReached
  • ThermalHouse.determineState should be renamed to updateState() since we update the state.
  • houses should be thermalHouses
@danielfeismann danielfeismann added the code quality Code readability or efficiency is improved label Feb 17, 2025
@danielfeismann danielfeismann mentioned this issue Feb 17, 2025
Merged
sebastian-peter added a commit that referenced this issue Feb 18, 2025
@sebastian-peter
Merge branch 'dev' into df/#1193-renaming-in-thermals
3ae75cf
sebastian-peter added a commit that referenced this issue Feb 18, 2025
@sebastian-peter
Merge pull request #1194 from ie3-institute/df/#1193-renaming-in-ther…
6ad5199 
…mals

Renamed some methods and variables within `ThermalGrid` and `ThermalH…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Code readability or efficiency is improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renamed some methods and variables within ThermalGrid and `ThermalH… ie3-institute/simona
1 participant
@danielfeismann