Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EM strategy is ignored #1091

Closed
sebastian-peter opened this issue Jan 7, 2025 · 0 comments · Fixed by #1092
Closed

EM strategy is ignored #1091

sebastian-peter opened this issue Jan 7, 2025 · 0 comments · Fixed by #1092
Assignees
@sebastian-peter
Labels
bug Something isn't working

Comments

@sebastian-peter
Copy link
Member

The model strategy set in EmInput is currently ignored in favor of this:

simona/src/main/scala/edu/ie3/simona/agent/grid/GridAgentController.scala

Lines 881 to 883 in 327fc46

maybeControllingEm
.map(_ => "PRIORITIZED")
.getOrElse("PROPORTIONAL"),

This needs to be fixed, of course.
@sebastian-peter sebastian-peter added the bug Something isn't working label Jan 7, 2025
@sebastian-peter sebastian-peter self-assigned this Jan 7, 2025
@sebastian-peter sebastian-peter mentioned this issue Jan 7, 2025
Merged
sebastian-peter added a commit that referenced this issue Jan 7, 2025
@sebastian-peter
Merge pull request #1092 from ie3-institute/sp/#1091-eminput-model-strat
925848f 
Using the EM model strategy set in EmInput
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastian-peter sebastian-peter

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using the EM model strategy set in EmInput ie3-institute/simona
1 participant
@sebastian-peter