Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeseries SQL source #496

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Timeseries SQL source #496

merged 4 commits into from
Jan 10, 2022

Conversation

sebastian-peter
Copy link
Member

Resolves #467

@sonarqubegithubprchecks

This comment has been minimized.

@sebastian-peter sebastian-peter force-pushed the sp/#467-sql-timeseries-source branch from 3263b17 to 2c0b041 Compare January 6, 2022 22:14
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #496 (0477ad7) into dev (4aa6394) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #496      +/-   ##
============================================
+ Coverage     78.78%   78.90%   +0.12%     
- Complexity     2083     2105      +22     
============================================
  Files           261      263       +2     
  Lines          8212     8273      +61     
  Branches        777      780       +3     
============================================
+ Hits           6470     6528      +58     
- Misses         1348     1349       +1     
- Partials        394      396       +2     
Impacted Files Coverage Δ
...du/ie3/datamodel/io/naming/FileNamingStrategy.java 92.85% <0.00%> (-1.20%) ⬇️
.../ie3/datamodel/io/source/sql/SqlWeatherSource.java 91.02% <0.00%> (-0.23%) ⬇️
...actory/timeseries/TimeBasedSimpleValueFactory.java 100.00% <0.00%> (ø)
...3/datamodel/io/source/sql/SqlTimeSeriesSource.java 91.66% <0.00%> (ø)
...odel/io/source/sql/SqlTimeSeriesMappingSource.java 100.00% <0.00%> (ø)
...del/io/naming/EntityPersistenceNamingStrategy.java 94.11% <0.00%> (+0.84%) ⬆️
...tamodel/models/input/system/type/ChpTypeInput.java 73.07% <0.00%> (+3.84%) ⬆️
...edu/ie3/datamodel/io/source/sql/SqlDataSource.java 71.42% <0.00%> (+4.76%) ⬆️
...atamodel/models/input/system/type/BmTypeInput.java 78.94% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04db918...0477ad7. Read the comment docs.

@sonarqubegithubprchecks

This comment has been minimized.

@sebastian-peter sebastian-peter marked this pull request as ready for review January 6, 2022 22:53
@sebastian-peter sebastian-peter force-pushed the sp/#467-sql-timeseries-source branch from 9f8b5d1 to 6898605 Compare January 6, 2022 22:54
@sebastian-peter
Copy link
Member Author

Note: I'm aware that SonarQube does not like SqlTimeSeriesSource.java#L50, but I do not know a solution that does not throw such a warning.

@sebastian-peter
Copy link
Member Author

!test

@sonarqubegithubprchecks

This comment has been minimized.

Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff, just minor things.
Not sure if it makes sense if someone else looks over this since I'm not too familiar with all that I/O PSDM stuff.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

1 Issue

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell1 Code Smell

Coverage and Duplications

  • 90 percent coverage94.85% Coverage (77.90% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.20% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

@t-ober t-ober merged commit 01337be into dev Jan 10, 2022
@t-ober t-ober deleted the sp/#467-sql-timeseries-source branch January 10, 2022 14:55
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement SqlTimeSeriesSource and SqlTimeSeriesMappingSource
2 participants