-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeseries SQL source #496
Conversation
This comment has been minimized.
This comment has been minimized.
3263b17
to
2c0b041
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## dev #496 +/- ##
============================================
+ Coverage 78.78% 78.90% +0.12%
- Complexity 2083 2105 +22
============================================
Files 261 263 +2
Lines 8212 8273 +61
Branches 777 780 +3
============================================
+ Hits 6470 6528 +58
- Misses 1348 1349 +1
- Partials 394 396 +2
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
9f8b5d1
to
6898605
Compare
Note: I'm aware that SonarQube does not like |
!test |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff, just minor things.
Not sure if it makes sense if someone else looks over this since I'm not too familiar with all that I/O PSDM stuff.
src/main/java/edu/ie3/datamodel/io/naming/FileNamingStrategy.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/naming/FileNamingStrategy.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/naming/FileNamingStrategy.java
Outdated
Show resolved
Hide resolved
Analysis Details1 IssueCoverage and DuplicationsProject ID: edu.ie3:PowerSystemDataModel |
Resolves #467