Improvements to ipkg files for dependancies. #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iPKG files have a new option `pkgs` which takes a comma-separated list of package names that the idris project depends on. This reduces bloat in the `opts` option with mutliple package declarations. So rather than have: ``` package foo opts = "-p lightyear -p containers -p tests -p pruviloj -p effects -p x --log 4" ``` we can now sayL ``` package foo opts = "--log 4" pkgs = lightyear, containers, tests, pruviloj, effects, x ```
| @@ -101,3 +113,4 @@ pClause = do reserved "executable"; lchar '='; | |||
| st <- get | |||
| put st { idris_tests = idris_tests st ++ ts } | |||
|
|
|||
| -- -------------------------------------------------------------------- [ EOF ] | |||
There was a problem hiding this comment.
What is the point of this comment?
|
This is a nice feature to add - thanks for doing it! I added a couple questions as line annotations. |
| -- Copyright : (c) The Idris Community. | ||
| -- License : see LICENSE | ||
| -- | ||
| -- The parser for Idris ipkg files. |
There was a problem hiding this comment.
This is a good thing to add - but shouldn't it be a Haddock module description instead of a comment?
|
i'll remove the 'extra' comments, they are just styling and visual aides I use when working with most source files. |
|
Looks great! Once Travis is done, I'll merge and then go add support to @archaeron: FYI, this is incoming, and the Atom mode should be made to understand it. |
|
awesome! I like this a lot more. @david-christiansen and thanks for the heads up :) |
melted
added a commit
that referenced
this pull request
Sep 28, 2015
Improvements to ipkg files for dependancies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iPKG files have a new option
pkgswhich takes a comma-separated listof package names that the idris project depends on. This reduces bloat
in the
optsoption with mutliple package declarations.So rather than have:
we can now say:
The file
PkgParser.hsfile was also cleaned up a little.