-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing param on transformers 4.4 #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Just one minor thing for the style check and then could you also update the minimum version for transformers
in
Line 73 in 6ea3b75
"transformers>=4.41.1", |
I still get this error off your head of dev
I had a patch that worked for transformers 4.42.3: But 4.43.1+ broke that further. |
I had to patch transformers itself a bit to work-around my issues: h2oai/h2ogpt#1771 Maybe affects caching behavior and slows things down, unsure. |
This was necessary for me on MacOS, not sure if others need it.