add examples:tracing and tracing-otlp #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gudaoxuri
reviewed
May 13, 2023
| @@ -42,6 +42,9 @@ pub struct FrameworkConfig { | |||
| /// Config center configuration / 配置中心的配置 | |||
| #[cfg(feature = "conf-remote")] | |||
| pub conf_center: Option<ConfCenterConfig>, | |||
| /// Tracing configuration / 链路追踪配置 | |||
| #[cfg(feature = "tracing")] | |||
| pub tracing: Option<TracingConfig>, | |||
There was a problem hiding this comment.
这个对象包含了日志级别及tracing，在未启用feature = "tracing"时连日志级别都不能设置了。
建议将对象重命名为
pub struct LogConfig {
pub level: String,
#[cfg(feature = "tracing")]
pub endpoint: String,
#[cfg(feature = "tracing")]
pub protocol: String,
#[cfg(feature = "tracing")]
pub server_name: String,
#[cfg(feature = "tracing")]
pub headers: Option<String>,
}
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.