Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test-container's version #144

Merged
merged 4 commits into from
Oct 18, 2024
Merged

update test-container's version #144

merged 4 commits into from
Oct 18, 2024

Conversation

4t145
Copy link
Collaborator

@4t145 4t145 commented Oct 16, 2024

No description provided.

let nacos = nacos.start().await.expect("fail to start nacos server");
let port = nacos.get_host_port_ipv4(8848).await.expect("fail to get nacos port");

let nacos_url = format!("{schema}://{ip}:{port}/nacos", schema = "http", ip = "127.0.0.1");

Check notice

Code scanning / devskim

Accessing localhost could indicate debug code, or could hinder scaling. Note test

Do not leave debug code in production
let redis_url = format!("redis://localhost:{port}/0", port = redis.get_host_port_ipv4(6379));
let redis = TardisTestContainer::redis_custom().await.expect("fail to start redis");
let port = redis.get_host_port_ipv4(6379).await.expect("fail to get redis port");
let redis_url = format!("redis://localhost:{port}/0");

Check notice

Code scanning / devskim

Accessing localhost could indicate debug code, or could hinder scaling. Note test

Do not leave debug code in production
@4t145 4t145 merged commit 69327a3 into main Oct 18, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant