Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c# -> vb custom event improvements #442

Merged
merged 4 commits into from
Nov 25, 2019

Conversation

Alexilia
Copy link
Contributor

fix conversion of custom event with backing field

Problem

#435

Solution

@GrahamTheCoder GrahamTheCoder merged commit 11e625d into icsharpcode:master Nov 25, 2019
@GrahamTheCoder
Copy link
Member

Thanks. I'm not quite sure whether it'll do any harm marking all private delegates as events. At some point we might need to do something cleverer, but this seems like a great first step.

If you're planning to contribute quite a bit of C# to VB conversion code, it's probably worth being aware of #8 (comment)
Paul converted the converter to VB, then worked on some improvements. At some point I was intending to convert his code back to C# and diff them (which will be quite messy) to see what could be merged back. I haven't got around to it yet, but it's possibly a good place to look for hints at minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants