Avoid VB assembly string comparison call where possible #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In VB's logic ((object) 3) = ((object) 3) returns true In C#, ((object) 3) == ((object) 3) returns false Easy to see the appeal of VB's approach for once
TODO: Simplify null coalesce when value coalesced is definitely not null
Using something like the NullableWalker (currently internal in Roslyn), or an open source null tracker would be more effective of course: https://github.com/mattwar/nullaby/blob/master/src/Nullaby/Analyzer/NullAnalyzer.cs
GrahamTheCoder
changed the title
This was referenced Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #105