Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to use project references to avoid reference conversion #165

Merged
merged 5 commits into from
Aug 19, 2018

Conversation

GrahamTheCoder
Copy link
Member

@GrahamTheCoder GrahamTheCoder commented Aug 18, 2018

Fixes #132

Problem

The previous issue was that copying metadata references directly between compilations wasn't working for CompilationReferences.

Solution

Originally I thought it was only possible to reference a compilation of the same type, and hence copying references wouldn't work, but now I suspect it just needs an accompanying project reference. This needs testing on a large repository with lots of references between projects ideally.

  • Give better progress feedback in the output window
  • At least one test covering the code changed (Would WholeSolution test cover this?)

@GrahamTheCoder GrahamTheCoder force-pushed the avoid-manual-compilation branch from aca11a2 to 38fb50a Compare August 19, 2018 11:18
The previous issue was that copying metadata references directly between compilations wasn't working for `CompilationReference`s.
Originally I thought it was only possible to reference a compilation of the same type, and hence copying references wouldn't work, but now I suspect it just needs an accompanying project reference
@GrahamTheCoder GrahamTheCoder force-pushed the avoid-manual-compilation branch from 38fb50a to f9fd765 Compare August 19, 2018 11:29
@GrahamTheCoder GrahamTheCoder changed the title WIP: Try to use project references to avoid reference conversion Try to use project references to avoid reference conversion Aug 19, 2018
@GrahamTheCoder GrahamTheCoder merged commit cbc3506 into master Aug 19, 2018
@GrahamTheCoder GrahamTheCoder deleted the avoid-manual-compilation branch August 19, 2018 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant