VB -> C#: VB float division (/) is converted as an integer division

[jrfstr]

VB.Net input code

Dim TotalRead as UInteger
Dim ContentLenght as UInteger  (It is supposed that TotalRead < ContentLength)
Dim porcentage As Integer = Convert.ToInt32((TotalRead / ContentLenght) * 100.0)

In VB TotalRead / ContentLenght is a float number. I guess the operands are converted to float before perform the division. Percentage can take all values between 0 and 100.

Erroneous output

uint TotalRead;
uint ContentLenght;
int porcentage = Convert.ToInt32(TotalRead / ContentLenght * 100.0d); 

Here TotalRead / ContentLenght is an integer and porcentaje only takes two values: 0 and 100

Expected output

int porcentage = Convert.ToInt32((double)TotalRead / (double)ContentLenght * 100.0d);

Details

• Product in use: Code Converter (VB - C#) (VS extension)
• Version in use: 9.2.6.0

[GrahamTheCoder]

Sorry I can't reproduce the issue

This might be some difficulty with the dot net version for example. What project type?
I assume you can't reproduce the issue here: https://icsharpcode.github.io/CodeConverter/

[jrfstr]

The dot net version is .NET 9.0. The project type is a class library (in VB).

In https://icsharpcode.github.io/CodeConverter/ I can't reproduce the issue. Things gone right there.

[jrfstr]

Sorry, that was not the code. Try this in the link:

Public Class VisualBasicClass
public sub x()
Dim TotalRead as long
Dim ContentLenght as long?  '(It is supposed that TotalRead < ContentLength)
Dim porcentage As Integer = Convert.ToInt32((TotalRead / ContentLenght) * 100.0)
End Sub
End Class

The output in c# is

using System;

public partial class VisualBasicClass
{
    public void x()
    {
        var TotalRead = default(long);
        var ContentLenght = default(long?);  // (It is supposed that TotalRead < ContentLength)
        int porcentage = Convert.ToInt32(TotalRead / ContentLenght * 100.0d);
    }
}

[GrahamTheCoder]

Yep that repros. It's an issue specifically with the logic around nullable not working correctly with logic around casting

[GrahamTheCoder]

I made a start on fixing up the issue, but there are a couple of situations in other tests that need thinking about before it could be merged

[jrfstr]

Thanks very much for your this project!