Check for success - hopefully fixes #653

icsharpcode · Oct 11, 2020 · c49f071 · c49f071
1 parent fba7ee8
commit c49f071
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/CodeConverter/ConversionResult.cs b/CodeConverter/ConversionResult.cs
@@ -11,7 +11,7 @@ public class ConversionResult
     {
         private string _sourcePathOrNull;
         private string _targetPathOrNull;
-        public bool Success { get; private set; }
+        public bool Success => ConvertedCode != null;
         public string ConvertedCode { get; private set; }
         public IReadOnlyList<string> Exceptions { get; internal set; }
         internal bool IsIdentity { get; set; }
@@ -28,13 +28,11 @@ public string TargetPathOrNull {
 
         public ConversionResult(string convertedCode = null)
         {
-            Success = convertedCode != null;
             ConvertedCode = convertedCode;
         }
 
         public ConversionResult(params Exception[] exceptions)
         {
-            Success = exceptions.Length == 0;
             Exceptions = exceptions.Select(e => e.ToString()).ToList();
         }
 

diff --git a/Vsix/CodeConversion.cs b/Vsix/CodeConversion.cs
@@ -125,15 +125,17 @@ private async Task WriteConvertedFilesAndShowSummaryAsync(IAsyncEnumerable<Conve
                 if (!string.IsNullOrWhiteSpace(exceptionsAsString)) {
                     errors.Add(exceptionsAsString);
                 }
+
+                if (convertedFile.Success) {
+                    files.Add(convertedFile.TargetPathOrNull);
 
-                files.Add(convertedFile.TargetPathOrNull);
+                    if (convertedFile.ConvertedCode.Length > longestFileLength) {
+                        longestFileLength = convertedFile.ConvertedCode.Length;
+                        longestFilePath = convertedFile.TargetPathOrNull;
+                    }
 
-                if (convertedFile.ConvertedCode.Length > longestFileLength) {
-                    longestFileLength = convertedFile.ConvertedCode.Length;
-                    longestFilePath = convertedFile.TargetPathOrNull;
+                    convertedFile.WriteToFile();
                 }
-
-                convertedFile.WriteToFile();
             }
 
             await FinalizeConversionAsync(files, errors, longestFilePath, filesToOverwrite);