Oracle tools #161
Merged
Oracle tools #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mond1c
changed the title
Mond1c
force-pushed
the
new-sniper-locator
branch
from
0b05658 to
adc2af2
Compare
Mond1c
force-pushed
the
new-sniper-locator
branch
from
dc371da to
9464164
Compare
|
I've created package.json with exports in common folder. I will add others files to this folder, but now I want to know if can I solve the copypaste problem this way? |
Mond1c
force-pushed
the
new-sniper-locator
branch
from
e95b698 to
85298c9
Compare
Mond1c
commented
Apr 3, 2024
Comment on lines
+1
to
+9
| import { AbstractWidgetService } from "shared-code/abstractWidget"; | ||
| import { BASE_URL_BACKEND, ADMIN_ACTIONS_WS_URL } from "../config"; | ||
|
|
||
| export class AbstractWidgetImpl extends AbstractWidgetService { | ||
| constructor(apiPath, errorHandler, listenWS) { | ||
| super(BASE_URL_BACKEND, ADMIN_ACTIONS_WS_URL, apiPath, errorHandler, listenWS); | ||
|
|
||
| } | ||
| } |
There was a problem hiding this comment.
Now admin only has the implementation and I hope I didn't break anything
Mond1c
force-pushed
the
new-sniper-locator
branch
from
a7449f1 to
80fd1e0
Compare
kbats183
approved these changes
Apr 3, 2024
MegaVerkruzo
pushed a commit
to MegaVerkruzo/live-v3
that referenced
this pull request
Apr 9, 2024
* init sniper locator controller * fix * fix type * delete dependency * change name * fix bugs * fix auth problem * fix eslint * added default username and password * mini refactored * fix mustExist flag + deleted useless get requests * fixed linter * create shared code * fix locator in overlay * rename to oracle-tools * fix package name * move abstractWidget.js to common folder * make abstractWidgetImpl for admin * added LOCATOR_MAGICAL_CONSTANT * fixed bugs + move BasicAuthKey to object * rename all parts of code from sniper to oracle --------- Co-authored-by: Mihail Kornilovich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will add Calibrator as a frontend compoent.
Locator is now separted from the admin frontend. And I want to know, is it a good idea? Or I need to get it back?