Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: icon txn result #78

Merged
merged 8 commits into from
Jun 14, 2023
Merged

feat: icon txn result #78

merged 8 commits into from
Jun 14, 2023

Conversation

izyak
Copy link
Collaborator

@izyak izyak commented Jun 8, 2023

No description provided.

@izyak izyak requested a review from viveksharmapoudel June 8, 2023 04:44
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #78 (5757f9f) into main (d0e4c82) will increase coverage by 0.83%.
The diff coverage is 47.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   12.11%   12.95%   +0.83%     
==========================================
  Files          68       68              
  Lines       15502    15566      +64     
==========================================
+ Hits         1878     2016     +138     
+ Misses      13420    13333      -87     
- Partials      204      217      +13     
Impacted Files Coverage Δ
relayer/chains/icon/client.go 15.38% <ø> (+5.07%) ⬆️
relayer/chains/icon/events.go 47.50% <ø> (ø)
relayer/chains/icon/provider.go 8.05% <ø> (+4.85%) ⬆️
relayer/chains/icon/query.go 0.00% <0.00%> (ø)
relayer/channel.go 0.00% <0.00%> (ø)
relayer/processor/path_end_runtime.go 0.00% <0.00%> (ø)
relayer/processor/types_internal.go 0.00% <ø> (ø)
relayer/chains/icon/tx.go 14.24% <58.15%> (+14.24%) ⬆️
relayer/chains/icon/msg.go 71.42% <100.00%> (+71.42%) ⬆️

@izyak izyak marked this pull request as draft June 8, 2023 06:18
@izyak izyak marked this pull request as ready for review June 12, 2023 04:58
Copy link
Collaborator

@viveksharmapoudel viveksharmapoudel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@viveksharmapoudel viveksharmapoudel merged commit b01d758 into main Jun 14, 2023
@viveksharmapoudel viveksharmapoudel deleted the feat/icon-txn-result branch June 14, 2023 10:35
izyak added a commit to izyak/ibc-relay-test that referenced this pull request Sep 7, 2023
* feat: Add method to get ports

* feat: Fix get txn result for icon

* fix: Do not get result for update client on goroutine

* fix: refractor and handle for channelclose init message

---------

Co-authored-by: izyak <[email protected]>
Co-authored-by: viveksharmapoudel <[email protected]>
izyak added a commit that referenced this pull request Sep 8, 2023
* feat: Add method to get ports

* feat: Fix get txn result for icon

* fix: Do not get result for update client on goroutine

* fix: refractor and handle for channelclose init message

---------

Co-authored-by: izyak <[email protected]>
Co-authored-by: viveksharmapoudel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants