feat(javascore): implement IBCModule on xCall app #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redlarva
force-pushed
the
implement-ibc-module-to-xcall
branch
from
74221f6 to
7bcf7aa
Compare
redlarva
force-pushed
the
implement-ibc-module-to-xcall
branch
from
896661e to
6a3d347
Compare
AntonAndell
requested changes
Apr 12, 2023
contracts/javascore/xcall/src/main/java/foundation/icon/btp/xcall/CallServiceImpl.java
Outdated
Show resolved
Hide resolved
contracts/javascore/xcall/src/main/java/foundation/icon/btp/xcall/CallServiceImpl.java
Outdated
Show resolved
Hide resolved
contracts/javascore/xcall/src/main/java/foundation/icon/btp/xcall/CallServiceImpl.java
Outdated
Show resolved
Hide resolved
contracts/javascore/xcall/src/main/java/foundation/icon/btp/xcall/CallServiceImpl.java
Outdated
Show resolved
Hide resolved
| import foundation.icon.score.client.ScoreInterface; | ||
|
|
||
| @ScoreInterface | ||
| public interface IMock { |
There was a problem hiding this comment.
Is this used anywhere?
There was a problem hiding this comment.
Yes it is used create empty MockContract for contract address.
There was a problem hiding this comment.
You can use sm.createScoreAccount for this, MockContracts are only useful to mock and verify method calls.
changes as per IIP52 standards set packet timeout to 0
AntonAndell
pushed a commit
that referenced
this pull request
Apr 24, 2023
* update build.gradle to implement IBC project * update settings.gradle to implement use xCall * move and update xCall service for IBC * add xCall readme * move and update xCall service for IBC * update xCall to support IBC messages on HandleBTPMessage * remove tests for now * feat(javascore): implement IBCModule on xCall app (#228) * feat(javascore): implement IBCModule on xCall app * feat: IIBC-26-javascore-xcall-contract-code-update-review (#286) * remove commented test files * remove commented lines for ```checkService``` * set destinationChannel from counterPartyChannelId * use sequenceNumber from IBCHandler for IBC specific sequence number for IBC Message. * remove order for ```setTimeoutHeight_unauthorized()``` as they are tested on separate deployments * remove order as they are tested on separate deployments --------- Co-authored-by: redlarva <[email protected]> Co-authored-by: Night Owl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: