Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocm: support rocBLAS 3.0 trmm with 3 matrices A, B, C #78

Merged
2 commits merged into from
Mar 15, 2024

Conversation

mgates3
Copy link
Collaborator

@mgates3 mgates3 commented Mar 15, 2024

rocBLAS 3.0 in ROCm 5.6.0 introduced a 3 matrix trmm, with separate B and C matrices that can be aliased. See
https://rocblas.readthedocs.io/en/master/API_Reference_Guide.html#rocblas-xtrmm-batched-strided-batched
This updates BLAS++ to call the new interface when available.

Also print the CPU and GPU BLAS version, where known. Tested on various systems:

pangolin blaspp> ./test/tester
BLAS++ version 2023.11.05, id 92ad3b4f,  OpenBLAS 0.3.21 

pangolin blaspp> ./test/tester
BLAS++ version 2023.11.05, id 92ad3b4f, Apple Accelerate

methane blaspp> ./test/tester 
BLAS++ version 2023.11.05, id 92ad3b4f, Intel MKL 2023.0.2, CUDA 11.0.0

dopamine blaspp> ./test/tester
BLAS++ version 2023.11.05, id 92ad3b4f, Intel MKL 2023.0.2, ROCm 5.7.1

@mgates3
Copy link
Collaborator Author

mgates3 commented Mar 15, 2024

Tested on Frontier. ROCm ≤ 5.5.1 uses the original 2 matrix trmm. ROCm ≥ 5.6.0 uses the new 3 matrix trmm.

@mgates3 mgates3 closed this pull request by merging all changes into icl-utk-edu:master in 92ad3b4 Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant