Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the NPM version via a marker or environment variable. #24

Merged
merged 1 commit into from
Jan 23, 2016

Conversation

phw
Copy link
Contributor

@phw phw commented Jan 22, 2016

This is an attempt to solve #22. A npm version can be set either via the NPM_VERSION_URL environment variable or by setting the .openshift/NPM_VERSION_URL marker.

Two things might be worth discussing:

  1. I also allow setting the npm version via an environment variable. This is a direct result of Problem with auto scaling #23, not sure whether you want to include this.

  2. In theory there is no need to use a semver.io URL, npm install could resolve the version. So instead of setting an URL we could just allow setting the version and npm would handle something like npm install -g [email protected]. The reason I chose the URL approach anyway are:

    a) It is consistent on how the node version gets resolved
    b) It is more flexible, e.g. I could run my own service where I can configure the node and npm version to use for all my gears

@icflorescu
Copy link
Owner

Thanks, Philipp, and sorry for not being able to reply sooner. This definitely looks interesting and will hopefully pull it tomorrow. I'll also make sure to update the README.

@icflorescu icflorescu merged commit 34b6fec into icflorescu:master Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants