-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions: Run unit tests on Python 3.13 #622
Conversation
I will automatically update this comment whenever this PR is modified
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #622 +/- ##
===============================================
- Coverage 71.88% 66.90% -4.98%
===============================================
Files 37 35 -2
Lines 3112 3058 -54
Branches 422 422
===============================================
- Hits 2237 2046 -191
- Misses 764 925 +161
+ Partials 111 87 -24 ☔ View full report in Codecov by Sentry. |
Waiting on numba/numba#9413, which in turn is waiting on Collecting numba (from datashader->icepyx==1.3.1.dev10+g16b2ffd)
Downloading numba-0.60.0.tar.gz (2.7 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.7/2.7 MB 28.2 MB/s eta 0:00:00
Installing build dependencies: started
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Getting requirements to build wheel: finished with status 'error'
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [24 lines of output]
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.13.0/x64/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
main()
~~~~^^
File "/opt/hostedtoolcache/Python/3.13.0/x64/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
~~~~^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/hostedtoolcache/Python/3.13.0/x64/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
File "/tmp/pip-build-env-w55jox8j/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 332, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=[])
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/pip-build-env-w55jox8j/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 302, in _get_build_requires
self.run_setup()
~~~~~~~~~~~~~~^^
File "/tmp/pip-build-env-w55jox8j/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 516, in run_setup
super().run_setup(setup_script=setup_script)
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/pip-build-env-w55jox8j/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 318, in run_setup
exec(code, locals())
~~~~^^^^^^^^^^^^^^^^
File "<string>", line 51, in <module>
File "<string>", line 48, in _guard_py_ver
RuntimeError: Cannot install on Python version 3.13.0; only versions >=3.9,<3.13 are supported.
[end of output] |
Blocked waiting for requirements.txt: |
@cclauss Should we go ahead and merge with your fix, or would it be better to wait for |
We can wait... We should not use a dependency's pre-release version in production. |
numba v0.61.0 has been released... https://pypi.org/project/numba/0.61.0/#history |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Datashader 0.17.0 came out, so Python 3.13 tests are passing now 🎉
@JessicaS11 I think we are ready when you are. 🚀 |
https://www.python.org/downloads/release/python-3130/
https://pythoninsider.blogspot.com/2024/10/python-3130-final-released.html
https://devguide.python.org/versions
Python 3.13 support numba/numba#9682requirements.txt:numba==0.61.0rc2; python_version == '3.13' # FIX ME!!!
https://pypi.org/project/numba/#historyhttps://github.com/numba/numba/releasesBlocked by:compat: Numba 0.61 and Python 3.13 holoviz/datashader#1373