-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #229: Pinning xarray to avoid issues with underlying call to pa… #230
Fixes #229: Pinning xarray to avoid issues with underlying call to pa… #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning xarray version still causes error.
Cause of #229 was Pandas >= 2.0.0 (see #229 (comment))
Also, not strictly necessary, but would prefer if if pinning was set specifically just for 3.8, to not be too restrictive for future versions.
pandas<2; python_version == '3.8'
xarray[io]<2023.2.0; python_version == '3.8'
xarray[io]; python_version > '3.8'
Updated the changes, though I'm not keen on pinning solely for specific python versions as it makes it more likely we develop against newer features. I think this makes the case for eventual dropping of 3.8, but let's pick that up for the 0.3 branch if that's OK? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a typo.
3cddd58
to
f4bd00a
Compare
👍🏼 |
…necessary to fix the broken operational forecasts. Already dealt with in 0.3 dev