Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #229: Pinning xarray to avoid issues with underlying call to pa… #230

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

JimCircadian
Copy link
Member

@JimCircadian JimCircadian commented Mar 16, 2024

…necessary to fix the broken operational forecasts. Already dealt with in 0.3 dev

@JimCircadian JimCircadian requested a review from bnubald March 16, 2024 15:22
@JimCircadian JimCircadian self-assigned this Mar 16, 2024
Copy link
Collaborator

@bnubald bnubald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning xarray version still causes error.

Cause of #229 was Pandas >= 2.0.0 (see #229 (comment))

Also, not strictly necessary, but would prefer if if pinning was set specifically just for 3.8, to not be too restrictive for future versions.

pandas<2; python_version == '3.8'
xarray[io]<2023.2.0; python_version == '3.8'
xarray[io]; python_version > '3.8'

@JimCircadian JimCircadian requested a review from bnubald March 18, 2024 23:38
@JimCircadian
Copy link
Member Author

Pinning xarray version still causes error.

Cause of #229 was Pandas >= 2.0.0 (see #229 (comment))

Also, not strictly necessary, but would prefer if if pinning was set specifically just for 3.8, to not be too restrictive for future versions.

pandas<2; python_version == '3.8'
xarray[io]<2023.2.0; python_version == '3.8'
xarray[io]; python_version > '3.8'

Updated the changes, though I'm not keen on pinning solely for specific python versions as it makes it more likely we develop against newer features.

I think this makes the case for eventual dropping of 3.8, but let's pick that up for the 0.3 branch if that's OK?

Copy link
Collaborator

@bnubald bnubald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a typo.

@bnubald
Copy link
Collaborator

bnubald commented Mar 21, 2024

Pinning xarray version still causes error.
Cause of #229 was Pandas >= 2.0.0 (see #229 (comment))
Also, not strictly necessary, but would prefer if if pinning was set specifically just for 3.8, to not be too restrictive for future versions.

pandas<2; python_version == '3.8'
xarray[io]<2023.2.0; python_version == '3.8'
xarray[io]; python_version > '3.8'

Updated the changes, though I'm not keen on pinning solely for specific python versions as it makes it more likely we develop against newer features.

I think this makes the case for eventual dropping of 3.8, but let's pick that up for the 0.3 branch if that's OK?

👍🏼

@JimCircadian JimCircadian merged commit 1ae4045 into icenet-ai:v0.2.8_dev Mar 21, 2024
@JimCircadian JimCircadian deleted the 229_xarray_pinning branch March 21, 2024 10:58
@bnubald bnubald linked an issue Apr 10, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to pin (temporarily) to an older version of xarray
2 participants