Avoid sharing State when re-parsing markdown sections

iced-rs · Feb 2, 2025 · 599d8b5 · 599d8b5
1 parent 569ef13
commit 599d8b5
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/widget/src/markdown.rs b/widget/src/markdown.rs
@@ -129,12 +129,6 @@ impl Content {
 
         // Re-parse incomplete sections if new references are available
         if !self.incomplete.is_empty() {
-            let mut state = State {
-                leftover: String::new(),
-                references: self.state.references.clone(),
-                highlighter: None,
-            };
-
             self.incomplete.retain(|index, section| {
                 if self.items.len() <= *index {
                     return false;
@@ -147,11 +141,19 @@ impl Content {
                     .retain(|link| !self.state.references.contains_key(link));
 
                 if broken_links_before != section.broken_links.len() {
+                    let mut state = State {
+                        leftover: String::new(),
+                        references: self.state.references.clone(),
+                        highlighter: None,
+                    };
+
                     if let Some((item, _source, _broken_links)) =
                         parse_with(&mut state, &section.content).next()
                     {
                         self.items[*index] = item;
                     }
+
+                    drop(state);
                 }
 
                 !section.broken_links.is_empty()