Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle relative urls in next link #130

Merged
merged 6 commits into from
Feb 23, 2025
Merged

Conversation

imranq2
Copy link
Contributor

@imranq2 imranq2 commented Feb 22, 2025

The changes introduce a new utility class UrlChecker in helix_fhir_client_sdk/utilities/url_checker.py with two static methods:
is_absolute_url(): Checks if a given URL is absolute
convert_relative_url_to_absolute_url(): Converts a relative URL to an absolute URL using a base URL
In the _get_with_session_async method of request_queue_mixin.py, the code now checks if the next_url is absolute, and if not, converts it to an absolute URL using the base URL.

Copy link

github-actions bot commented Feb 22, 2025

Qodana Community for Python

1 new problem were found

Inspection name Severity Problems
Class has no init method ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@imranq2 imranq2 merged commit 64877d4 into main Feb 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants