Skip to content

Commit

Permalink
remove vpc beta sdk reference (#309)
Browse files Browse the repository at this point in the history
  • Loading branch information
deepaksibm authored Oct 30, 2023
1 parent 685bea6 commit bf3909f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ func DataSourceIBMIsVirtualNetworkInterface() *schema.Resource {
}

func dataSourceIBMIsVirtualNetworkInterfaceRead(context context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
vpcbetaClient, err := meta.(conns.ClientSession).VpcV1API()
vpcClient, err := meta.(conns.ClientSession).VpcV1API()
if err != nil {
return diag.FromErr(err)
}
Expand All @@ -413,7 +413,7 @@ func dataSourceIBMIsVirtualNetworkInterfaceRead(context context.Context, d *sche

getVirtualNetworkInterfaceOptions.SetID(d.Get("virtual_network_interface").(string))

virtualNetworkInterface, response, err := vpcbetaClient.GetVirtualNetworkInterfaceWithContext(context, getVirtualNetworkInterfaceOptions)
virtualNetworkInterface, response, err := vpcClient.GetVirtualNetworkInterfaceWithContext(context, getVirtualNetworkInterfaceOptions)
if err != nil {
log.Printf("[DEBUG] GetVirtualNetworkInterfaceWithContext failed %s\n%s", err, response)
return diag.FromErr(fmt.Errorf("GetVirtualNetworkInterfaceWithContext failed %s\n%s", err, response))
Expand Down
12 changes: 0 additions & 12 deletions ibm/service/vpc/data_source_ibm_is_virtual_network_interfaces.go
Original file line number Diff line number Diff line change
Expand Up @@ -443,18 +443,6 @@ func dataSourceIBMIsVirtualNetworkInterfacesRead(context context.Context, d *sch
return diag.FromErr(fmt.Errorf("VirtualNetworkInterfacesPager.GetAll() failed %s", err))
}

// var pager *vpcv1.VirtualNetworkInterfacesPager
// pager, err = vpcbetaClient.NewVirtualNetworkInterfacesPager(listVirtualNetworkInterfacesOptions)
// if err != nil {
// return diag.FromErr(err)
// }

// allItems, err := pager.GetAll()
// if err != nil {
// log.Printf("[DEBUG] VirtualNetworkInterfacesPager.GetAll() failed %s", err)
// return diag.FromErr(fmt.Errorf("VirtualNetworkInterfacesPager.GetAll() failed %s", err))
// }

d.SetId(dataSourceIBMIsVirtualNetworkInterfacesID(d))

mapSlice := []map[string]interface{}{}
Expand Down
9 changes: 4 additions & 5 deletions ibm/service/vpc/resource_ibm_is_security_group_target.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (
"github.com/IBM-Cloud/terraform-provider-ibm/ibm/conns"
"github.com/IBM-Cloud/terraform-provider-ibm/ibm/flex"
"github.com/IBM-Cloud/terraform-provider-ibm/ibm/validate"
"github.com/IBM/vpc-beta-go-sdk/vpcbetav1"
"github.com/IBM/vpc-go-sdk/vpcv1"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
Expand Down Expand Up @@ -127,7 +126,7 @@ func resourceIBMISSecurityGroupTargetCreate(d *schema.ResourceData, meta interfa
return errsgt
}
} else if crn != nil && *crn != "" && strings.Contains(*crn, "virtual_network_interfaces") {
vpcClient, err := meta.(conns.ClientSession).VpcV1BetaAPI()
vpcClient, err := meta.(conns.ClientSession).VpcV1API()
if err != nil {
return err
}
Expand Down Expand Up @@ -338,7 +337,7 @@ func isLBSgTargetRefreshFunc(sess *vpcv1.VpcV1, lbId string) resource.StateRefre
}
}

func isWaitForVNISgTargetCreateAvailable(sess *vpcbetav1.VpcbetaV1, vniId string, timeout time.Duration) (interface{}, error) {
func isWaitForVNISgTargetCreateAvailable(sess *vpcv1.VpcV1, vniId string, timeout time.Duration) (interface{}, error) {
log.Printf("Waiting for virtual network interface (%s) to be available.", vniId)

stateConf := &resource.StateChangeConf{
Expand All @@ -353,10 +352,10 @@ func isWaitForVNISgTargetCreateAvailable(sess *vpcbetav1.VpcbetaV1, vniId string
return stateConf.WaitForState()
}

func isVNISgTargetRefreshFunc(vpcClient *vpcbetav1.VpcbetaV1, vniId string) resource.StateRefreshFunc {
func isVNISgTargetRefreshFunc(vpcClient *vpcv1.VpcV1, vniId string) resource.StateRefreshFunc {
return func() (interface{}, string, error) {

getVNIOptions := &vpcbetav1.GetVirtualNetworkInterfaceOptions{
getVNIOptions := &vpcv1.GetVirtualNetworkInterfaceOptions{
ID: &vniId,
}
vni, response, err := vpcClient.GetVirtualNetworkInterface(getVNIOptions)
Expand Down

0 comments on commit bf3909f

Please sign in to comment.