Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] Add support for improved SLS flow in the CLI #53

Merged
merged 19 commits into from
Jan 30, 2025
Merged

[minor] Add support for improved SLS flow in the CLI #53

merged 19 commits into from
Jan 30, 2025

Conversation

rawa-resul
Copy link
Contributor

@rawa-resul rawa-resul commented Jan 12, 2025 •
edited
Loading

Description

  • Added pandoc-*-x86_64-macOS.pkg to .gitignore as it was missing for macs
  • Added getNamespace function in ocp.py
  • Created new file src/mas/devops/sls.py:
    • Added listSLSInstances function
    • Added findSLSByNamespace function
  • Converted slsLicenseFile to use secretsAPI.create() like the other secrets
    • Also, the secret with the actual license file now gets created within the cli
  • Added sls_action optional param for sls in pipelinerun-install.yml.j2

Testing

  • All of the above have been tested via the CLI

@rawa-resul rawa-resul self-assigned this Jan 12, 2025
@rawa-resul rawa-resul mentioned this pull request Jan 12, 2025
Merged
@rawa-resul rawa-resul changed the title [minor] Add support for various SLS configurations [minor] Add support for improved SLS flow in the CLI Jan 23, 2025
@rawa-resul rawa-resul marked this pull request as ready for review January 27, 2025 13:52
whitfiea
whitfiea requested changes Jan 30, 2025
View reviewed changes
@rawa-resul rawa-resul requested a review from whitfiea January 30, 2025 14:58
@whitfiea whitfiea enabled auto-merge January 30, 2025 15:00
@whitfiea whitfiea added this pull request to the merge queue Jan 30, 2025
Merged via the queue into stable with commit 13b803a Jan 30, 2025
2 checks passed
@whitfiea whitfiea deleted the sls-rr branch January 30, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitfiea whitfiea whitfiea approved these changes

@durera durera Awaiting requested review from durera durera is a code owner

@JonahLuckett JonahLuckett Awaiting requested review from JonahLuckett JonahLuckett is a code owner

@andrercm andrercm Awaiting requested review from andrercm andrercm is a code owner

@sanjayprab sanjayprab Awaiting requested review from sanjayprab sanjayprab is a code owner

@terenceq terenceq Awaiting requested review from terenceq terenceq is a code owner

@alequint alequint Awaiting requested review from alequint alequint is a code owner

@leo-miran leo-miran Awaiting requested review from leo-miran leo-miran is a code owner

Assignees

@rawa-resul rawa-resul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rawa-resul @whitfiea