Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] Add missing Maximo IT command flag to doc #973

Merged
merged 3 commits into from
May 22, 2024
Merged

[patch] Add missing Maximo IT command flag to doc #973

merged 3 commits into from
May 22, 2024

Conversation

andrercm
Copy link
Contributor

@andrercm andrercm commented May 18, 2024 •
edited
Loading

Fix for : #856

whitfiea
whitfiea previously requested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@whitfiea whitfiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does --mirror-icd actually do anything? I can't see where it is used other than in this doc page?

@andrercm
Copy link
Contributor Author

@whitfiea I haven't implemented it, just fixing the docs for it, but it should be used by the mirror_add_manage playbook to mirror Maximo IT images along with Manage's images:

https://github.com/ibm-mas/ansible-devops/blob/master/ibm/mas_devops/playbooks/mirror_add_manage.yml#L34

@durera
Copy link
Contributor

durera commented May 22, 2024

Does --mirror-icd actually do anything? I can't see where it is used other than in this doc page?

Yup, it does ... it controls the setting of the MIRROR_MAS_ICD env var, which the mas mirror-images command passes through to the playbook that drives the image mirroring process.

@durera durera changed the title [patch] Include Maximo IT in readme [patch] Add missing Maximo IT command flag to doc May 22, 2024
@durera durera merged commit 7eda58c into master May 22, 2024
3 checks passed
@durera durera deleted the fix-icd-docs branch May 22, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitfiea whitfiea whitfiea left review comments

@durera durera Awaiting requested review from durera durera is a code owner

@terenceq terenceq Awaiting requested review from terenceq terenceq is a code owner

@alequint alequint Awaiting requested review from alequint alequint is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrercm @durera @whitfiea