Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] DRO installation using cli command #537

Merged
merged 55 commits into from
Nov 8, 2023
Merged

Conversation

MrunaliniKankariya2
Copy link
Contributor

@MrunaliniKankariya2 MrunaliniKankariya2 commented Oct 3, 2023

This PR includes changes for DRO installation. It has following changes

  1. mas install will install DRO with mas core installation, which will need 4 parameters email, firstname, lastname and token
  2. mas update will check for existing UDS installation. If found it will ask user if UDS need to uninstall and DRO should be installed. If user say 'yes' then UDS will be uninstalled and DRO installed else only DRO will be installed
  3. mas unistall should also uninstall DRO
    Testing done:
    I have tested installation and update on cluster - https://console-openshift-console.apps.mas-core-plg.cp.fyre.ibm.com/k8s/ns/mas-drotest-pipelines/tekton.dev~v1beta1~PipelineRun/drotest-upgrade-mz7kf/logs

Copy link
Contributor

@whitfiea whitfiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrunaliniKankariya2 is this still a draft as per the PR first description? Can you edit this first description to say what this change does and what testing you have done? Also the title says migration but the description says install and uninstall

@whitfiea whitfiea marked this pull request as draft October 5, 2023 06:46
@MrunaliniKankariya2 MrunaliniKankariya2 marked this pull request as ready for review October 12, 2023 10:53
@MrunaliniKankariya2 MrunaliniKankariya2 changed the title [minor] DRO migration into cli command [minor] DRO installation using cli command Oct 12, 2023
@lokesh-sreedhara
Copy link
Contributor

lokesh-sreedhara commented Oct 12, 2023

@MrunaliniKankariya2 can u resolve the conflicts? can u sync up with Yuvraj about the latest changes? We decided to add a new variable called BAS_ACTION , which allows the users to install either uds or dro . can u make similar changes to cli to accept either uds or dro options?

hari and me reviewed this PR, i think here uds is being replaced by dro. can we have both install options instead?

whitfiea
whitfiea previously approved these changes Oct 31, 2023
@MrunaliniKankariya2 MrunaliniKankariya2 merged commit 1f84a0c into master Nov 8, 2023
@MrunaliniKankariya2 MrunaliniKankariya2 deleted the dro-migration branch November 8, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants