Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Align IoT and SLS mustgather with function parameter change #529

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

stonepd
Copy link
Contributor

@stonepd stonepd commented Sep 28, 2023

There is a bug in the SLS and IoT mustgather -

[must-gather] Error from server (BadRequest): Unable to find "/v1, Resource=pods" that match label selector "ibm-iot-operator=/workspace/mustgather/fvtnocpd-fvt-847/20230928-080426", field selector "": unable to parse requirement: values[0][ibm-iot-operator]: Invalid value: "/workspace/mustgather/fvtnocpd-fvt-847/20230928-080426": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')
[must-gather] error executing jsonpath "{.items[0].[metadata.name](http://metadata.name/)}": Error executing template: array index out of bounds: index 0, length 0. Printing more information for debugging the template:
[must-gather] 	template was:
[must-gather] 		{.items[0].[metadata.name](http://metadata.name/)}
[must-gather] 	object given to jsonpath engine was:
[must-gather] 		map[string]interface {}{"apiVersion":"v1", "items":[]interface {}{}, "kind":"List", "metadata":map[string]interface {}{"resourceVersion":"", "selfLink":""}}
...
etc
...

Delivery of #462 crossed over with #453 which changed the function parameters of mg-collect-reconcile-logs, so we need to pass in the label name control-plane in most cases.

@whitfiea whitfiea changed the title [patch] align IoT and SLS mustgather with function parameter change [patch] Align IoT and SLS mustgather with function parameter change Sep 28, 2023
@stonepd stonepd merged commit 65aa3e6 into master Sep 28, 2023
@stonepd stonepd deleted the jira-ibmiot-61 branch September 28, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants