[minor] Add Health FVT pipeline #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3492970.
karlinglee93
requested review from
durera,
andrercm,
sanjayprab,
terenceq and
whitfiea
as code owners
whitfiea
requested changes
Sep 18, 2023
There was a problem hiding this comment.
@karlinglee93 Can you confirm that the tests pass as well? Rather than just the test task runs?
Hi @whitfiea , I cannot guarantee every test would pass, because there are around 600 test cases. And We keep monitoring and fixing the defects every day and the pass rate right now is around 70% (Our best result is over 95% before). We prefer to onboard the pipeline first, and keep improving the pass rate. Do you agree? |
whitfiea
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Health pipeline to master branch.
Changes have been tested fully on my personal fvt cluster - healthjn.