Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] Support Manage custom encryption keys and CPD services with block storage #439

Merged
merged 30 commits into from
Aug 30, 2023
Merged

[minor] Support Manage custom encryption keys and CPD services with block storage #439

merged 30 commits into from
Aug 30, 2023

Conversation

andrercm
Copy link
Contributor

@andrercm andrercm commented Aug 24, 2023 •
edited
Loading

  • Added support for custom encryption keys for Manage database (instead of using only autogenerated by default Manage install)
  • Added support to customize the industry solutions and add-ons to be installed as part of Manage (this has been an old request from business partners)

image

Requires this ansible-devops PR to be merged: ibm-mas/ansible-devops#972

FVT Personal tests passed:

image

andrercm and others added 22 commits August 18, 2023 23:51
@andrercm
[minor] initial dev for manage encryption secrets
c6ecbcc
@andrercm
[patch] rebuild cli
5091f53
@andrercm
[patch] rebuild new ansible-devops
9a79f57
@andrercm
Merge branch 'master' of github.com:ibm-mas/cli into fixes-cpd-manage
26a4a6a
@andrercm
[patch] rebuild ansible-devops
0d42940
@andrercm
[patch] rebuild cli
5001ad8
@andrercm
Merge branch 'master' of github.com:ibm-mas/cli into fixes-cpd-manage
5734e9d
@andrercm
[patch] add crypto params and MAS_APPWS_COMPONENTS
8b2af10
@andrercm
[patch] fix mas_app_settings_crypto_key param
1966c76
@andrercm
[patch] enclose if
a349c45
@andrercm
[patch] rebuild ansible devops
98e5e98
@andrercm
[patch] fix manage addons prompt
142e049
@andrercm
[patch] fix enclosing if
2f7bfed
@andrercm
[patch] fix labeling
0d7b4f1
@andrercm
[patch] fix empty MAS_APPWS_COMPONENTS condition
6122969
@andrercm
[patch] adjust text labels
da523b8
@andrercm
[patch] remove ref grafana in debug
e717233
@andrercm
[patch] add MAS_APPWS_COMPONENTS in pipelinerun
bb0adfb
@andrercm
[patch] base=latest,health=latest as default
f5b21f0
@andrercm
[patch] rephrase
cb2b63f
@andrercm
[patch] rebuild ansible devops
5d01f61
@andrercm
Merge branch 'master' into fixes-cpd-manage
d7cc556
@andrercm
Copy link
Contributor Author

Running final tests at the moment...

@andrercm andrercm marked this pull request as ready for review August 25, 2023 14:01
@andrercm andrercm requested a review from alequint August 25, 2023 14:02
@andrercm andrercm mentioned this pull request Aug 25, 2023
Closed
whitfiea
whitfiea approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@whitfiea whitfiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whitfiea whitfiea merged commit 8693c47 into master Aug 30, 2023
@whitfiea whitfiea deleted the fixes-cpd-manage branch August 30, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitfiea whitfiea whitfiea approved these changes

@durera durera Awaiting requested review from durera durera is a code owner

@sanjayprab sanjayprab Awaiting requested review from sanjayprab sanjayprab is a code owner

@terenceq terenceq Awaiting requested review from terenceq terenceq is a code owner

@alequint alequint Awaiting requested review from alequint alequint is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrercm @whitfiea