Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Optional Watson Studio bind to Health #418

Merged
merged 21 commits into from
Aug 31, 2023
Merged

[minor] Optional Watson Studio bind to Health #418

merged 21 commits into from
Aug 31, 2023

Conversation

alequint
Copy link
Contributor

@alequint alequint commented Aug 15, 2023

PRs:

Please refer to CLI PR for a complete description of the new binding requested by Health team.


About optional studio binding

This PR allows users to optionally bind Watson Studion with Health (in ManageWorkspace CR)

In order to do that a new parameter has been added in PIpeline:

mas_appws_bindings_health_wsl_flag

By default, it isfalse, but can be set as true, indicating CPD and Studio must be provisioned and bound to Manage

  • In regular FVT environments, this parameter will be informed via travis, received by ansible-fvt and then used in PipelineRun
  • In CLI, a y/N question will be asked when user chooses to install Manage; when Y, MAS_APPWS_BINDINGS_HEALTH_WSL_FLAGwill be set astrue and so will be informed in PipelineRun

When install or install-with-fvt pipelines are parameterized with mas_appws_bindings_health_wsl = system, three tasks will be enabled.

  • cp4d-platform
  • cp4d-wsl
  • suite-config-wsl

... as they had their when criteria modified accordingly:

- input: "$(params.mas_app_channel_predict)$(params.mas_app_channel_hputilities)$(params.mas_app_channel_assist)$(params.mas_appws_bindings_health_wsl_flag)"
      operator: notin
      values: [""]

suite-app-config task will then receive this new parameter and based on that will modify ManageWorkspace CR bindings and, besides jdbc, will include studio as defined here

Test Evidences:

In CLI

image

In FVT

Copy link
Contributor

@whitfiea whitfiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alequint alequint marked this pull request as draft August 22, 2023 17:57
@alequint alequint marked this pull request as ready for review August 24, 2023 22:05
@alequint alequint requested a review from whitfiea August 24, 2023 22:05
@alequint alequint dismissed whitfiea’s stale review August 28, 2023 21:57

This item has already been addressed (zip file was removed)

andrercm
andrercm previously approved these changes Aug 30, 2023
Copy link
Contributor

@andrercm andrercm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alequint
Copy link
Contributor Author

As devops has been merged: ibm-mas/ansible-devops#979
And given the re-review performed: #418 (review)

I will merge this 👍

@alequint alequint merged commit d511fa2 into master Aug 31, 2023
@alequint alequint deleted the healthfvt branch August 31, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants